Small optimization on change sex

[Daegaladh]

• Addressed Issue(s): N/A

• Server Mode: Both

• Description of Pull Request: Small optimization when changing sex from sex specific classes.

[aleos89]

A little longer but I see no issue in that since now it's much safer and less assumptions about the expected class.

[SapitoSucio]

Could be done like this too, to shrink it a lil bit

switch (class_) {
	case JOB_BARD: class_ = JOB_DANCER; break;
	case JOB_DANCER: class_ = JOB_BARD; break;
	case JOB_CLOWN: class_ = JOB_GYPSY; break;
	...

[Daegaladh]

Could be done like this too, to shrink it a lil bit

switch (class_) {
	case JOB_BARD: class_ = JOB_DANCER; break;
	case JOB_DANCER: class_ = JOB_BARD; break;
	case JOB_CLOWN: class_ = JOB_GYPSY; break;
	...

I could, but I thought it would be clearer this way

[aleos89]

Could be done like this too, to shrink it a lil bit

switch (class_) {

	case JOB_BARD: class_ = JOB_DANCER; break;

	case JOB_DANCER: class_ = JOB_BARD; break;

	case JOB_CLOWN: class_ = JOB_GYPSY; break;

	...

As my professor always said, white space is free when developing!