-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated npcspeed, npcwalkto and npcstop script commands #8354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atemo
added
mode:renewal
A fault that exists within the renewal mode
status:code-review
Pull Request that requires reviewing from other developers before being pushed to master
labels
May 23, 2024
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
Export DEFAULT_NPC_WALK_SPEED, MIN_WALK_SPEED and MAX_WALK_SPEED
aleos89
approved these changes
May 29, 2024
Co-authored-by: Aleos <aleos89@users.noreply.github.com>
Lemongrass3110
approved these changes
Jun 13, 2024
src/map/script.cpp
Outdated
} | ||
unit_stop_walking( &nd->bl, USW_FIXPOS | USW_MOVE_FULL_CELL | USW_FORCE_STOP ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just because I see that you added USW_FORCE_STOP here.
Do we want to make flag a parameter?
Lemongrass3110
added
component:core
A fault that lies within the main framework of rAthena
mode:prerenewal
A fault that exists within the pre-renewal mode
type:enhancement
Issue that is an enhancement to rAthena
labels
Jun 13, 2024
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
* the parameter is the same as for the unitstopwalk script command
secretdataz
reviewed
Jun 14, 2024
Atemo
removed
the
status:code-review
Pull Request that requires reviewing from other developers before being pushed to master
label
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:core
A fault that lies within the main framework of rAthena
mode:prerenewal
A fault that exists within the pre-renewal mode
mode:renewal
A fault that exists within the renewal mode
type:enhancement
Issue that is an enhancement to rAthena
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the optional parameter
<npc name>
tonpcspeed
to change the walking speed of the npc with the said name.Usage :
npcspeed( <speed value> {,"<npc name>"} );
Added the optional parameter
<npc name>
tonpcwalkto
to move the npc with the said name at the given coordinates.Usage :
npcwalkto( <x>,<y> {,"<npc name>"} } );
Added the optional parameters
<npc name>
and<flag>
tonpcstop
to stop the movement of the npc with the said name with options.Usage :
npcstop( {"<npc name>", {"<flag>"}});