Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated npcspeed, npcwalkto and npcstop script commands #8354

Merged
merged 11 commits into from
Jun 16, 2024
Merged

Conversation

Atemo
Copy link
Contributor

@Atemo Atemo commented May 23, 2024

  • Addressed Issue(s): -
  • Server Mode: Both
  • Description of Pull Request:
  • Added the optional parameter <npc name> to npcspeed to change the walking speed of the npc with the said name.
    Usage : npcspeed( <speed value> {,"<npc name>"} );

  • Added the optional parameter <npc name> to npcwalkto to move the npc with the said name at the given coordinates.
    Usage : npcwalkto( <x>,<y> {,"<npc name>"} } );

  • Added the optional parameters <npc name> and <flag> to npcstop to stop the movement of the npc with the said name with options.
    Usage : npcstop( {"<npc name>", {"<flag>"}});

@Atemo Atemo added mode:renewal A fault that exists within the renewal mode status:code-review Pull Request that requires reviewing from other developers before being pushed to master labels May 23, 2024
doc/script_commands.txt Outdated Show resolved Hide resolved
src/map/script.cpp Outdated Show resolved Hide resolved
src/map/script.cpp Outdated Show resolved Hide resolved
src/map/script.cpp Outdated Show resolved Hide resolved
src/map/script.cpp Outdated Show resolved Hide resolved
src/map/script.cpp Outdated Show resolved Hide resolved
src/map/script.cpp Outdated Show resolved Hide resolved
src/map/script.cpp Outdated Show resolved Hide resolved
src/map/script.cpp Outdated Show resolved Hide resolved
Atemo and others added 2 commits May 26, 2024 21:10
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
Export DEFAULT_NPC_WALK_SPEED, MIN_WALK_SPEED and MAX_WALK_SPEED
doc/script_commands.txt Outdated Show resolved Hide resolved
src/map/script.cpp Show resolved Hide resolved
}
unit_stop_walking( &nd->bl, USW_FIXPOS | USW_MOVE_FULL_CELL | USW_FORCE_STOP );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just because I see that you added USW_FORCE_STOP here.
Do we want to make flag a parameter?

@Lemongrass3110 Lemongrass3110 added component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode type:enhancement Issue that is an enhancement to rAthena labels Jun 13, 2024
Atemo and others added 2 commits June 13, 2024 19:51
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
* the parameter is the same as for the unitstopwalk script command
@Atemo Atemo merged commit 6451925 into master Jun 16, 2024
31 checks passed
@Atemo Atemo deleted the update/npcspeed branch June 16, 2024 12:58
@Atemo Atemo removed the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode type:enhancement Issue that is an enhancement to rAthena
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants