feat: Add automated test for quick start test #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susanshi
requested review from
akashsinghal,
binbin-li,
jimmyraywv,
luisdlp and
toddysm
as code owners
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1045 +/- ##
=======================================
Coverage 58.34% 58.34%
=======================================
Files 93 93
Lines 5541 5541
=======================================
Hits 3233 3233
Misses 1992 1992
Partials 316 316 ☔ View full report in Codecov by Sentry. |
|
TODO for this PR: 1. Add a v tag trigger, but this MUST run after other publish activity ends.. 2. document in release activity so we should validate the result of this test |
binbin-li
reviewed
Aug 31, 2023
susanshi
commented
Sep 1, 2023
.github/workflows/quick-start.yml
Outdated
| - name: Save logs | ||
| if: ${{ always() }} | ||
| run: | | ||
| kubectl logs -n gatekeeper-system -l app=ratify --tail=-1 > logs-ratify-preinstall-${{ matrix.KUBERNETES_VERSION }}-${{ matrix.GATEKEEPER_VERSION }}-config-policy.json |
There was a problem hiding this comment.
remove gatekeeper version
Signed-off-by: Susan Shi <huish@microsoft.com>
binbin-li
approved these changes
Sep 1, 2023
bspaans
pushed a commit
to bspaans/ratify
that referenced
this pull request
Oct 17, 2023
Signed-off-by: Susan Shi <huish@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What this PR does / why we need it:
This test is useful for :
This test mirrors our quick start test, it will use helmfile to install dependencies and ran through steps in https://github.com/deislabs/ratify/blob/main/README.md#quick-start
Please see run result at https://github.com/susanshi/ratify/actions/runs/6031928385
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
mainbranch)How Has This Been Tested?
Please see run result at https://github.com/susanshi/ratify/actions/runs/6031928385
Checklist:
Post Merge Requirements
Helm Chart Change