Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add health Probe #1058

Merged
merged 26 commits into from
Sep 7, 2023
Merged

feat: add health Probe #1058

merged 26 commits into from
Sep 7, 2023

Conversation

susanshi
Copy link
Collaborator

@susanshi susanshi commented Sep 6, 2023

Description

fixes #977

What this PR does / why we need it:

  • add probe to deployment files
  • allow probe port to be configuration ( code changes required)

Tests:
validated default probe port
validated non default port
validated probe events appear in pod events

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Tests:
validated default probe port
validated non default port
validated probe events appear in pod events ( only failure appears in event log)

image

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 16.66% and project coverage change: -0.02% ⚠️

Comparison is base (40834b6) 58.32% compared to head (4a6683b) 58.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
- Coverage   58.32%   58.31%   -0.02%     
==========================================
  Files          93       93              
  Lines        5543     5546       +3     
==========================================
+ Hits         3233     3234       +1     
- Misses       1994     1996       +2     
  Partials      316      316              
Files Changed Coverage Δ
httpserver/server.go 43.80% <ø> (ø)
pkg/manager/manager.go 3.31% <0.00%> (-0.04%) ⬇️
cmd/ratify/cmd/serve.go 39.06% <50.00%> (+0.96%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susanshi susanshi marked this pull request as ready for review September 6, 2023 01:49
binbin-li
binbin-li previously approved these changes Sep 6, 2023
Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just 2 minor comments

Makefile Outdated Show resolved Hide resolved
test/bats/quickstart-test.bats Outdated Show resolved Hide resolved
binbin-li
binbin-li previously approved these changes Sep 6, 2023
@susanshi
Copy link
Collaborator Author

susanshi commented Sep 6, 2023

Hi @binbin-li , this is ready for another round of review. The HA test was failing due to something else was already running at 9090, i ve updated the default port to 9099

@susanshi susanshi enabled auto-merge (squash) September 7, 2023 01:11
@susanshi susanshi merged commit 3b271b8 into ratify-project:main Sep 7, 2023
18 of 20 checks passed
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Signed-off-by: Susan Shi <huish@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Readiness Probes
2 participants