Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update auth cache miss error handling #1105

Merged

Conversation

akashsinghal
Copy link
Collaborator

@akashsinghal akashsinghal commented Sep 28, 2023

Description

What this PR does / why we need it:

  • Updates cache providers to check for invalid TTL and emit log + fail early
  • Updates oras implementation to check if auth provider returned an empty auth config
  • Update docker auth provider to set a default TTL of 1 hour
  • Add tests

Logs don't show errors now for GHCR:
image

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #1025

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (baf48ef) 52.28% compared to head (d7a848e) 52.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1105      +/-   ##
==========================================
+ Coverage   52.28%   52.30%   +0.02%     
==========================================
  Files         101      101              
  Lines        6291     6305      +14     
==========================================
+ Hits         3289     3298       +9     
- Misses       2684     2688       +4     
- Partials      318      319       +1     
Files Coverage Δ
pkg/cache/dapr/dapr.go 62.96% <100.00%> (+2.96%) ⬆️
pkg/cache/ristretto/ristretto.go 74.57% <100.00%> (+1.84%) ⬆️
pkg/common/oras/authprovider/authprovider.go 47.22% <100.00%> (+3.10%) ⬆️
pkg/referrerstore/oras/oras.go 67.52% <33.33%> (-1.41%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akashsinghal akashsinghal self-assigned this Sep 28, 2023
Copy link
Collaborator

@luisdlp luisdlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these validations, seems straight forward. For the docker cred cahe ttl, do we have reference ttl from other auth providers?

pkg/common/oras/authprovider/authprovider.go Show resolved Hide resolved
luisdlp
luisdlp previously approved these changes Oct 3, 2023
Copy link
Collaborator

@luisdlp luisdlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/cache/dapr/dapr.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments

binbin-li
binbin-li previously approved these changes Oct 10, 2023
Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once all comments resolved.

@akashsinghal akashsinghal dismissed stale reviews from binbin-li and luisdlp via d7a848e October 10, 2023 17:09
@akashsinghal akashsinghal enabled auto-merge (squash) October 10, 2023 17:09
@akashsinghal akashsinghal merged commit 7645096 into ratify-project:main Oct 11, 2023
20 checks passed
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth cache failures when using public registry like ghcr
4 participants