Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update notation tsg doc link #1152

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

binbin-li
Copy link
Collaborator

Description

What this PR does / why we need it:

Update notation tsg doc link.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #1100

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a659b4) 52.24% compared to head (3a726ce) 52.39%.
Report is 1 commits behind head on main.

❗ Current head 3a726ce differs from pull request most recent head 65edec2. Consider uploading reports for the commit 65edec2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
+ Coverage   52.24%   52.39%   +0.15%     
==========================================
  Files          83      101      +18     
  Lines        5310     6344    +1034     
==========================================
+ Hits         2774     3324     +550     
- Misses       2284     2699     +415     
- Partials      252      321      +69     
Files Coverage Δ
pkg/verifier/notation/notation.go 83.01% <100.00%> (ø)

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

binbin-li and others added 2 commits October 30, 2023 16:39
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Akash Singhal <akashsinghal@microsoft.com>
@akashsinghal akashsinghal enabled auto-merge (squash) October 30, 2023 17:33
@akashsinghal akashsinghal merged commit 52c2c00 into ratify-project:main Oct 30, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change doc reference in the Ratify error log
2 participants