Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate plugin name on CR create #1265

Merged
merged 21 commits into from
Jan 30, 2024

Conversation

susanshi
Copy link
Collaborator

@susanshi susanshi commented Jan 17, 2024

Description

#1089
This PR adds substatus property to Verifier and Store CR. The controllers are also updated to validate plugin path.

What this PR does / why we need it:

  • Adding sub status to Verifier and Store CRD
  • Adding plugin path check on plugin creation
  • Fix a bug where Policy CR isn't writing the success status

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes # 1089

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Added unit test and e2e test for writing success and failure status in verifier and store

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@susanshi susanshi changed the title Check plugin name feat: validate plugin name on CR create Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (2be797d) 61.72% compared to head (354c5cb) 61.72%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/common/plugin/download.go 40.00% 2 Missing and 1 partial ⚠️
pkg/controllers/store_controller.go 82.35% 3 Missing ⚠️
pkg/controllers/verifier_controller.go 82.35% 3 Missing ⚠️
pkg/verifier/factory/factory.go 0.00% 2 Missing and 1 partial ⚠️
pkg/controllers/policy_controller.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1265      +/-   ##
==========================================
- Coverage   61.72%   61.72%   -0.01%     
==========================================
  Files          97       97              
  Lines        6190     6236      +46     
==========================================
+ Hits         3821     3849      +28     
- Misses       2038     2054      +16     
- Partials      331      333       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susanshi susanshi marked this pull request as ready for review January 24, 2024 00:22
@susanshi
Copy link
Collaborator Author

@junczhu , @akashsinghal , @binbin-li , this PR is ready for review when you get a chance, thanks!

Copy link
Collaborator

@akashsinghal akashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@susanshi susanshi merged commit 7abfc7f into ratify-project:main Jan 30, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants