Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix missing separator in helm template #1463

Merged
merged 2 commits into from
May 13, 2024

Conversation

binbin-li
Copy link
Collaborator

Description

What this PR does / why we need it:

We use range operator to iterate through cosignKeys and notationKeys to populate a series of KMPs. But we miss the separator in the range block which would only render the last KMP in each loop. Adding the separator to fix the problem.

The install command I tested:

noglob helm install ratify \
    ./charts/ratify --atomic \
    --namespace gatekeeper-system \
    --set image.pullPolicy=Always \
    --set-file cosignKeys[0]="./test1.pub" \
    --set-file cosignKeys[1]="./test2.pub" \
    --set-file notationCerts[0]="./test/testdata/notation.crt" \
    --set-file notationCerts[1]="./test/testdata/notation.crt" \
    --set featureFlags.RATIFY_CERT_ROTATION=true

Screenshot before the change:
image

Screenshot after the change:
image

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.16%. Comparing base (1bd347c) to head (86c017d).
Report is 18 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1463      +/-   ##
==========================================
+ Coverage   66.76%   68.16%   +1.39%     
==========================================
  Files         116      119       +3     
  Lines        6030     6134     +104     
==========================================
+ Hits         4026     4181     +155     
+ Misses       1620     1559      -61     
- Partials      384      394      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixing Binbin! LGTM.

@susanshi
Copy link
Collaborator

@binbin-li ,i m merging this into dev, so others who are buddying testing with local chart can have this fix.

@susanshi susanshi merged commit 2ee5904 into ratify-project:dev May 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants