Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go concurrency ORAS cache bug #401

Conversation

akashsinghal
Copy link
Collaborator

Signed-off-by: Akash Singhal akashsinghal@microsoft.com

Description

Fixes ORAS cache concurrency issue. ORAS error didn't match the error we were catching.

Fixes #391

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Kubernetes scenario with multiple containers with same image

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Signed-off-by: Akash Singhal <akashsinghal@microsoft.com>
Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sajayantony sajayantony merged commit 27f6e93 into ratify-project:main Nov 9, 2022
susanshi pushed a commit to evantravers18/ratify that referenced this pull request Nov 10, 2022
Signed-off-by: Akash Singhal <akashsinghal@microsoft.com>

Signed-off-by: Akash Singhal <akashsinghal@microsoft.com>
binbin-li pushed a commit to binbin-li/ratify that referenced this pull request Nov 18, 2022
Signed-off-by: Akash Singhal <akashsinghal@microsoft.com>

Signed-off-by: Akash Singhal <akashsinghal@microsoft.com>
fseldow pushed a commit to fseldow/ratify that referenced this pull request Dec 7, 2022
Signed-off-by: Akash Singhal <akashsinghal@microsoft.com>

Signed-off-by: Akash Singhal <akashsinghal@microsoft.com>
@akashsinghal akashsinghal deleted the akashsinghal/fixORASConcurrencyBug branch March 1, 2023 23:15
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Signed-off-by: Akash Singhal <akashsinghal@microsoft.com>

Signed-off-by: Akash Singhal <akashsinghal@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ORAS local store race condition
3 participants