Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade go to 1.20 to use coverage profiling for integration tests. #833

Merged
merged 1 commit into from
May 19, 2023

Conversation

binbin-li
Copy link
Collaborator

@binbin-li binbin-li commented May 17, 2023

Description

What this PR does / why we need it:

Upgrade go version to 1.20 to leverage coverage profiling support for integration tests.
This PR doesn’t make a big difference in the test coverage, but it adds 600 more lines to the reports.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #791

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Test coverage breakdown in main branch:
image
image

Test coverage breakdown in this PR:
image
image

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@binbin-li binbin-li changed the title feat: upgrade go to 1.20 feat: upgrade go to 1.20 to use coverage profiling for integration tests. May 17, 2023
@binbin-li binbin-li marked this pull request as draft May 17, 2023 06:44
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.09 🎉

Comparison is base (86a6789) 53.57% compared to head (ded7042) 54.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
+ Coverage   53.57%   54.66%   +1.09%     
==========================================
  Files          62       79      +17     
  Lines        3679     4615     +936     
==========================================
+ Hits         1971     2523     +552     
- Misses       1500     1815     +315     
- Partials      208      277      +69     

see 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@binbin-li binbin-li marked this pull request as ready for review May 17, 2023 07:22
@akashsinghal
Copy link
Collaborator

Thanks for taking care of this. I think we need to update the dockerfile image builder version here? https://github.com/deislabs/ratify/blob/86a67891fc1a2ffeb343b6e8d514ecd032499f2e/httpserver/Dockerfile#L2

@binbin-li binbin-li force-pushed the upgrade-go-1.20 branch 3 times, most recently from 0ac6d39 to bc5fcbe Compare May 18, 2023 08:13
Signed-off-by: Binbin Li <libinbin@microsoft.com>
@binbin-li binbin-li merged commit 6ac7461 into ratify-project:main May 19, 2023
14 checks passed
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
…sts. (ratify-project#833)

Signed-off-by: Binbin Li <libinbin@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use code coverage profiling provided by Go 1.20 to increase test coverage.
2 participants