Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: testscript change echo file to printf #859

Merged
merged 3 commits into from
May 31, 2023

Conversation

fseldow
Copy link
Contributor

@fseldow fseldow commented May 30, 2023

Description

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

e2e test will cover
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@fseldow fseldow changed the title [test] change echo file to printf test: change echo file to printf May 30, 2023
@fseldow fseldow changed the title test: change echo file to printf test: testscript change echo file to printf May 30, 2023
@fseldow fseldow marked this pull request as ready for review May 30, 2023 20:40
Makefile Outdated
@@ -121,7 +121,7 @@ delete-gatekeeper:

.PHONY: test-e2e
test-e2e: generate-rotation-certs
bats -t ${BATS_TESTS_FILE}
${GITHUB_WORKSPACE}/bin/bats -t ${BATS_TESTS_FILE}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious, why was this necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the in test-e2e-cli and all other binaray it is using ${GITHUB_WORKSPACE}/bin/xxx.
revert this change since export it into path can solve

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f7cf03c) 54.96% compared to head (06b37f5) 54.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #859   +/-   ##
=======================================
  Coverage   54.96%   54.96%           
=======================================
  Files          80       80           
  Lines        4739     4739           
=======================================
  Hits         2605     2605           
  Misses       1850     1850           
  Partials      284      284           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question as Akash, lgtm overall

@binbin-li binbin-li merged commit 908c355 into ratify-project:main May 31, 2023
14 checks passed
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants