-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: testscript change echo file to printf #859
Conversation
Makefile
Outdated
@@ -121,7 +121,7 @@ delete-gatekeeper: | |||
|
|||
.PHONY: test-e2e | |||
test-e2e: generate-rotation-certs | |||
bats -t ${BATS_TESTS_FILE} | |||
${GITHUB_WORKSPACE}/bin/bats -t ${BATS_TESTS_FILE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious, why was this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because the in test-e2e-cli and all other binaray it is using ${GITHUB_WORKSPACE}/bin/xxx
.
revert this change since export it into path can solve
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #859 +/- ##
=======================================
Coverage 54.96% 54.96%
=======================================
Files 80 80
Lines 4739 4739
=======================================
Hits 2605 2605
Misses 1850 1850
Partials 284 284 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question as Akash, lgtm overall
Description
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
e2e test will cover
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change