-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: create publish-sample.yml #900
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
=======================================
Coverage 54.95% 54.95%
=======================================
Files 81 81
Lines 4791 4791
=======================================
Hits 2633 2633
Misses 1881 1881
Partials 277 277 ☔ View full report in Codecov by Sentry. |
.github/workflows/publish-sample.yml
Outdated
# need to convert repo name to lowercase for Docker | ||
- name: Get repo | ||
run: | | ||
echo "REPO_OWNER=$(echo $GITHUB_REPOSITORY_OWNER | awk '{print tolower($0)}')" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our publishpackage workflow which publishes the images to ghcr, we use the github.repository
to get the deislabs/ratify
portion of the image ref. Will this be the equivalent? https://github.com/deislabs/ratify/blob/8f65ad2bf95f5baba6fd454bdd817cf24e0927a6/.github/workflows/publish-package.yml#L29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relevant docs it looks like: https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the tip!, ive updated the env various, and here what the output looks like on my fork:
Copied [registry] wabbitnetworks.azurecr.io/test/notary-image:signed => [registry] ghcr.io/susanshi/ratify/notary-image:signed
Digest: sha256:8e3d01113285a0e4aa574da8eb9c0f112a1eb979d72f73399d7175ba3cdb1c1b
Description
What this PR does / why we need it:
Moving our sample images to ghcr, target path :
ghcr.io/deislabs/ratify/notary-image:unsigned
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #889
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Tested on personal fork
Checklist: