Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create publish-sample.yml #900

Merged
merged 5 commits into from
Jun 27, 2023

Conversation

susanshi
Copy link
Collaborator

@susanshi susanshi commented Jun 23, 2023

Description

What this PR does / why we need it:

Moving our sample images to ghcr, target path :
ghcr.io/deislabs/ratify/notary-image:unsigned

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #889

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Tested on personal fork

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

@susanshi susanshi changed the title Create publish-sample.yml chore: create publish-sample.yml Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4ba8328) 54.95% compared to head (b64e3f0) 54.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #900   +/-   ##
=======================================
  Coverage   54.95%   54.95%           
=======================================
  Files          81       81           
  Lines        4791     4791           
=======================================
  Hits         2633     2633           
  Misses       1881     1881           
  Partials      277      277           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

# need to convert repo name to lowercase for Docker
- name: Get repo
run: |
echo "REPO_OWNER=$(echo $GITHUB_REPOSITORY_OWNER | awk '{print tolower($0)}')" >> $GITHUB_ENV
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our publishpackage workflow which publishes the images to ghcr, we use the github.repository to get the deislabs/ratify portion of the image ref. Will this be the equivalent? https://github.com/deislabs/ratify/blob/8f65ad2bf95f5baba6fd454bdd817cf24e0927a6/.github/workflows/publish-package.yml#L29

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the tip!, ive updated the env various, and here what the output looks like on my fork:

Copied [registry] wabbitnetworks.azurecr.io/test/notary-image:signed => [registry] ghcr.io/susanshi/ratify/notary-image:signed
Digest: sha256:8e3d01113285a0e4aa574da8eb9c0f112a1eb979d72f73399d7175ba3cdb1c1b

@susanshi susanshi enabled auto-merge (squash) June 27, 2023 00:37
@susanshi susanshi merged commit 8621536 into ratify-project:main Jun 27, 2023
15 checks passed
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Quickstart assets to a permanent subscription
2 participants