Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update quick start to ghcr image #906

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

susanshi
Copy link
Collaborator

Description

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8c4320d) 54.95% compared to head (83a959b) 54.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #906   +/-   ##
=======================================
  Coverage   54.95%   54.95%           
=======================================
  Files          81       81           
  Lines        4791     4791           
=======================================
  Hits         2633     2633           
  Misses       1881     1881           
  Partials      277      277           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@susanshi susanshi marked this pull request as ready for review June 28, 2023 05:30
Copy link
Collaborator

@akashsinghal akashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! We can update our testing pipeline in a follow up PR?

Do we need to update the docs on the website too?

@luisdlp
Copy link
Collaborator

luisdlp commented Jun 28, 2023

Ditto, thanks for looking into this. Once this is merged, we should let Yi and Xinhe know so that they update the docs.
How did you get the images in the registry?

@susanshi
Copy link
Collaborator Author

Thanks for the update! We can update our testing pipeline in a follow up PR?

Do we need to update the docs on the website too?

For our azure e23 testing pipeline, we should continue using wabbitnetwork, for non azure test, i believe we are doing local registry ? Good point on the website, i ll check what needs to be updated

@susanshi susanshi merged commit 2c6f7a2 into ratify-project:main Jun 29, 2023
15 checks passed
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants