Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publish ratify image with plugin #916

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

susanshi
Copy link
Collaborator

@susanshi susanshi commented Jul 4, 2023

Description

What this PR does / why we need it:

We updated the build step to optionally build the plugin, see PR [860], (https://github.com/deislabs/ratify/pull/860/files#diff-9c427950275d8aad2e8016fd20f5615c15acda7205793165fe31d45748ee0e9d), but our publish workflow is not currently passing in of the params.
The immdiate fix , we need to update our publish workflow to build ratify image with the plugin. We also have a test gap here , we should also have test run against latest released version

Which issue(s) this PR fixes :

Fixes # 915

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (b7be0fb) 54.95% compared to head (5f85ae1) 55.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #916      +/-   ##
==========================================
+ Coverage   54.95%   55.01%   +0.06%     
==========================================
  Files          81       81              
  Lines        4791     4791              
==========================================
+ Hits         2633     2636       +3     
+ Misses       1881     1879       -2     
+ Partials      277      276       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix!

@susanshi
Copy link
Collaborator Author

susanshi commented Jul 4, 2023

Please see sample run in my fork, https://github.com/susanshi/ratify/actions/runs/5451620505/jobs/9918074924

@susanshi susanshi marked this pull request as ready for review July 4, 2023 07:22
@susanshi
Copy link
Collaborator Author

susanshi commented Jul 4, 2023

@akashsinghal , @luisdlp , let us know if you have additional feedback on the PR. @binbin-li and I spoke, we think its worth release a fix to RC5. Binbin will be working on a proposal on the workflow.

Copy link
Collaborator

@akashsinghal akashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thanks for the fix!

@susanshi susanshi merged commit 555b762 into ratify-project:main Jul 5, 2023
15 checks passed
susanshi added a commit that referenced this pull request Jul 6, 2023
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants