-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: publish ratify image with plugin #916
fix: publish ratify image with plugin #916
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #916 +/- ##
==========================================
+ Coverage 54.95% 55.01% +0.06%
==========================================
Files 81 81
Lines 4791 4791
==========================================
+ Hits 2633 2636 +3
+ Misses 1881 1879 -2
+ Partials 277 276 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the fix!
Please see sample run in my fork, https://github.com/susanshi/ratify/actions/runs/5451620505/jobs/9918074924 |
@akashsinghal , @luisdlp , let us know if you have additional feedback on the PR. @binbin-li and I spoke, we think its worth release a fix to RC5. Binbin will be working on a proposal on the workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Thanks for the fix!
Description
What this PR does / why we need it:
We updated the build step to optionally build the plugin, see PR [860], (https://github.com/deislabs/ratify/pull/860/files#diff-9c427950275d8aad2e8016fd20f5615c15acda7205793165fe31d45748ee0e9d), but our publish workflow is not currently passing in of the params.
The immdiate fix , we need to update our publish workflow to build ratify image with the plugin. We also have a test gap here , we should also have test run against latest released version
Which issue(s) this PR fixes :
Fixes # 915
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change