Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use latest sbom-tool #917

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

binbin-li
Copy link
Collaborator

@binbin-li binbin-li commented Jul 4, 2023

Description

What this PR does / why we need it:

Reverting this PR as sbom-tool already fixed the broken release.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1a0130f) 54.95% compared to head (da90237) 54.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #917   +/-   ##
=======================================
  Coverage   54.95%   54.95%           
=======================================
  Files          81       81           
  Lines        4791     4791           
=======================================
  Hits         2633     2633           
  Misses       1881     1881           
  Partials      277      277           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -340,7 +339,7 @@ e2e-sbom-setup:
mkdir -p .staging/sbom

# Install sbom-tool
curl -Lo .staging/sbom/sbom-tool https://github.com/microsoft/sbom-tool/releases/download/v${SBOM_TOOL_VERSION}/sbom-tool-linux-x64 && chmod +x .staging/sbom/sbom-tool
curl -Lo .staging/sbom/sbom-tool https://github.com/microsoft/sbom-tool/releases/latest/download/sbom-tool-linux-x64 && chmod +x .staging/sbom/sbom-tool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure want to pin to latest versus a specific version? We had some experiences in the pst where the upstream tool latest version introduced breaking changes that started causing CI tests to fail.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's good point. I feel CI test failure is not a big concern in this case since it's a quick fix, but we should consider if we want to always use the latest version with probably more validation and potential bugs or a specific version that we've verified. We can leave PR open and discuss in the community.

Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had a discussion with during community meeting, we agreed on using latest version as this will then be insync with the dependabot managed version in src code.

@binbin-li binbin-li merged commit 249f5f4 into ratify-project:main Jul 6, 2023
14 checks passed
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Co-authored-by: Susan Shi <huish@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants