Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV data rows aren't escaped at all #1

Closed
waded opened this issue May 15, 2020 · 0 comments · Fixed by #5
Closed

CSV data rows aren't escaped at all #1

waded opened this issue May 15, 2020 · 0 comments · Fixed by #5

Comments

@waded
Copy link
Member

waded commented May 15, 2020

If a table's resultset's cell contains a comma, the CSV output will be malformed, since the CSV isn't escaped (e.g. w/ quotes) at all.

Use a real CSV encoder instead of joining on commas.
waded added a commit that referenced this issue May 16, 2020
@waded
Refactor/test toward #1
e0282a4
waded added a commit that referenced this issue May 17, 2020
@waded
Fix #1 (encoding issue with CSV) and various others
aa4a0d1
@waded waded mentioned this issue May 17, 2020
Merged
@waded waded closed this as completed in #5 May 17, 2020
waded added a commit that referenced this issue May 17, 2020
@waded
v2 (#5)
dfb360f 
* Simpler way to support PORT over other options

* No need to manually use urandom

* No reason to have preferIPV4Stack

* Update to Java 14

* Fix a couple grammar, typo, link issues in readme

* Stop using 1.x sourceCompat style

* Update Spring Boot

* Update io.spring.dependency-management

* Simplify file handling

* Clarify #4

* Refactor/test toward #1

* Relative path seems to work here

* Add additional error handle test

* Fix warns

* Reduce number of unsupported types

* Match comment to implementation

* Adding \r\n to test an IMPORTDATA issue

* Fix #1 (encoding issue with CSV) and various others

* Require public.tableau.com.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v2 rationalagents/twbxless
1 participant
@waded