Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce @ExecSegment annotation to replace @NonBlocking. #1192

Open
ldaley opened this issue Apr 12, 2017 · 3 comments · May be fixed by #1474
Open

Introduce @ExecSegment annotation to replace @NonBlocking. #1192

ldaley opened this issue Apr 12, 2017 · 3 comments · May be fixed by #1474
Milestone
release-2.0.0

Comments

@ldaley
Copy link
Member

ldaley commented Apr 12, 2017

This annotation will indicate that a plain action is wrapped in an Operation when executed and can therefore use Operation/Promise within the action safely.
@ldaley ldaley added this to the release-1.6.0 milestone Apr 12, 2017
@ldaley ldaley modified the milestones: release-1.6.0, release-2.0.0 Jan 9, 2018
@michaelschlies
Copy link
Contributor

Should this be applied in all locations that @NonBlocking is currently in use today that the criteria of being wrapped in an Operation or Promise is true?

@michaelschlies michaelschlies linked a pull request Aug 18, 2019 that will close this issue
Open
@michaelschlies
Copy link
Contributor

@ldaley is the intention that @NonBlocking should be @Deprecated or removed as well then?

@johnrengelman
Copy link
Member

An example of where this annotation would be used is here: https://github.com/ratpack/ratpack/blob/master/ratpack-exec/src/main/java/ratpack/exec/Operation.java#L149

The user supplied Action is wrapped in Operation.of(() -> action.execute(......))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release-2.0.0
Development

Successfully merging a pull request may close this issue.

Add Annotation interface for ExecSegment
3 participants
@ldaley @michaelschlies @johnrengelman