Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Annotation interface for ExecSegment #1474

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Annotation interface for ExecSegment #1474

wants to merge 2 commits into from

Conversation

michaelschlies
Copy link
Contributor

@michaelschlies michaelschlies commented Aug 18, 2019

fixes #1192

Please see note in #1192 before merging, this hasn't been added to any places NonBlocking is presently.


This change is Reviewable

@michaelschlies michaelschlies changed the title Add Annotation interface Add Annotation interface for ExecSegment Aug 18, 2019
@codecov-io
Copy link

Codecov Report

Merging #1474 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1474   +/-   ##
=========================================
  Coverage     73.76%   73.76%           
- Complexity     4551     4553    +2     
=========================================
  Files           652      652           
  Lines         17017    17017           
  Branches       1428     1428           
=========================================
  Hits          12552    12552           
  Misses         3843     3843           
  Partials        622      622
Impacted Files Coverage Δ Complexity Δ
...ile/internal/CachingFileSystemChecksumService.java 72.72% <0%> (-9.1%) 2% <0%> (-1%)
.../src/main/java/ratpack/reactor/ReactorRatpack.java 81.48% <0%> (-5.56%) 17% <0%> (ø)
...in/java/ratpack/exec/internal/CachingUpstream.java 88.57% <0%> (+1.42%) 20% <0%> (+1%) ⬆️
...ack/exec/util/internal/DefaultReadWriteAccess.java 84.55% <0%> (+1.62%) 29% <0%> (+1%) ⬆️
...a/ratpack/stream/internal/ManagedSubscription.java 70.83% <0%> (+2.08%) 21% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81dabc7...4eb20b4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce @ExecSegment annotation to replace @NonBlocking.
2 participants