upgrade to gradle 5.1 and groovy 2.5.x, closes #1412 #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drmaas
changed the title
drmaas
changed the title
|
Can we upgrade to 5.1 before merge? |
drmaas
changed the title
|
Aside from some site compile/test issues, this build worked locally. Biggest change is requiring gradle 4.0+ when using the ratpack plugin (due to shadow plugin requiring that). |
johnrengelman
approved these changes
Jan 19, 2019
| @@ -135,7 +135,7 @@ abstract class FunctionalSpec extends Specification { | |||
| } | |||
|
|
|||
| File getShadowJar() { | |||
| def f = file("build/libs/test-app-1.0-all.jar") | |||
| def f = file("build/libs/test-app-1.0.jar") | |||
There was a problem hiding this comment.
I reverted this change because this is a bug in Shadow on Gradle 5.1+ due to this: https://docs.gradle.org/5.1/userguide/upgrading_version_5.html#change_in_behavior_for_tasks_extending_abstractarchivetask_or_subtypes_zip_jar_war_ear_tar
Instead, we should update the build.gradle in the test to explicitly set the classifier value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is