Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle trailing slashes in HttpUrlBuilder #1444

Merged
merged 1 commit into from Apr 22, 2019
Merged

Conversation

johnrengelman
Copy link
Member

@johnrengelman johnrengelman commented Apr 20, 2019

This change is Reviewable

@codecov-io
Copy link

Codecov Report

Merging #1444 into master will increase coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1444      +/-   ##
============================================
+ Coverage     73.74%   73.75%   +0.01%     
- Complexity     4529     4533       +4     
============================================
  Files           649      649              
  Lines         16993    16995       +2     
  Branches       1424     1424              
============================================
+ Hits          12531    12535       +4     
+ Misses         3844     3840       -4     
- Partials        618      620       +2
Impacted Files Coverage Δ Complexity Δ
...a/ratpack/http/internal/DefaultHttpUrlBuilder.java 87.39% <75%> (-0.64%) 38 <3> (+2)
.../http/client/internal/IdlingConnectionHandler.java 66.66% <0%> (-33.34%) 2% <0%> (-1%)
...ratpack/exec/internal/ExecutionBoundPublisher.java 86.44% <0%> (-1.7%) 3% <0%> (ø)
...a/ratpack/stream/internal/SubscriptionSupport.java 76.62% <0%> (+1.29%) 20% <0%> (+1%) ⬆️
...va/ratpack/spring/config/RatpackConfiguration.java 70.96% <0%> (+6.45%) 3% <0%> (+1%) ⬆️
...a/ratpack/stream/internal/ForkingSubscription.java 72.41% <0%> (+10.34%) 4% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60b0ff8...4b73924. Read the comment docs.

@johnrengelman johnrengelman merged commit 259717a into master Apr 22, 2019
@johnrengelman johnrengelman deleted the trailing-slash branch April 22, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants