Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose option for TCP keep alive #1679

Merged
merged 2 commits into from Aug 3, 2023
Merged

Expose option for TCP keep alive #1679

merged 2 commits into from Aug 3, 2023

Conversation

ldaley
Copy link
Member

@ldaley ldaley commented Aug 3, 2023

This change is Reviewable

@ldaley ldaley self-assigned this Aug 3, 2023
@ldaley ldaley added the new label Aug 3, 2023
@ldaley ldaley added this to the release-1.10.0 milestone Aug 3, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 37.14% and project coverage change: +0.04% 🎉

Comparison is base (093091b) 73.27% compared to head (c8323b9) 73.31%.
Report is 12 commits behind head on 1.10.x.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             1.10.x    #1679      +/-   ##
============================================
+ Coverage     73.27%   73.31%   +0.04%     
- Complexity     4830     4837       +7     
============================================
  Files           695      695              
  Lines         18366    18372       +6     
  Branches       1518     1521       +3     
============================================
+ Hits          13457    13470      +13     
+ Misses         4211     4203       -8     
- Partials        698      699       +1     
Files Changed Coverage Δ
...ore/src/main/java/ratpack/server/ServerConfig.java 100.00% <ø> (ø)
.../main/java/ratpack/server/ServerConfigBuilder.java 40.00% <ø> (ø)
...xec/src/main/java/ratpack/exec/ExecController.java 100.00% <ø> (+25.00%) ⬆️
...ctor/internal/BlockingExecutorBackedScheduler.java 0.00% <0.00%> (ø)
.../rx2/internal/BlockingExecutorBackedScheduler.java 0.00% <0.00%> (ø)
...ient/internal/ContentAggregatingRequestAction.java 65.00% <9.09%> (-21.21%) ⬇️
...client/internal/ContentStreamingRequestAction.java 80.80% <10.00%> (-9.08%) ⬇️
...ck/exec/internal/DefaultExecControllerBuilder.java 52.94% <50.00%> (-11.77%) ⬇️
.../internal/module/ServerConfigDataDeserializer.java 91.54% <100.00%> (+5.24%) ⬆️
.../ratpack/server/internal/DefaultRatpackServer.java 86.77% <100.00%> (+0.67%) ⬆️
... and 5 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldaley ldaley merged commit 31e6fdd into 1.10.x Aug 3, 2023
4 checks passed
@ldaley ldaley deleted the so_keepalive branch August 3, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants