Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swallow exception when client side session cookie is bogus #1703

Merged
merged 1 commit into from Jan 12, 2024

Conversation

ldaley
Copy link
Member

@ldaley ldaley commented Jan 11, 2024

This change is Reviewable

@ldaley ldaley self-assigned this Jan 11, 2024
@ldaley ldaley added this to the release-1.10.0 milestone Jan 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (b451c18) 73.29% compared to head (b8416a7) 73.26%.

Files Patch % Lines
...on/clientside/internal/ClientSideSessionStore.java 60.86% 8 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             1.10.x    #1703      +/-   ##
============================================
- Coverage     73.29%   73.26%   -0.03%     
- Complexity     4891     4893       +2     
============================================
  Files           695      695              
  Lines         18486    18495       +9     
  Branches       1541     1541              
============================================
+ Hits          13549    13551       +2     
- Misses         4242     4243       +1     
- Partials        695      701       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldaley ldaley merged commit 6555fc7 into 1.10.x Jan 12, 2024
4 checks passed
@ldaley ldaley deleted the ldaley/discard-malformed-client-side-session-cookies branch January 12, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants