Remove unnecessary and unused fixtures

ratt-ru · Nov 13, 2023 · 4ff3f47 · 4ff3f47
1 parent b716137
commit 4ff3f47
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/daskms/conftest.py b/daskms/conftest.py
@@ -311,18 +311,13 @@ def minio_server(tmp_path_factory):
         server_process.kill()
 
 
-@pytest.fixture
-def minio_alias():
-    return "testcloud"
-
-
 @pytest.fixture
 def minio_user_key():
     return "abcdef1234567890"
 
 
 @pytest.fixture
-def minio_admin(minio_server, minio_alias, minio_user_key):
+def minio_admin(minio_server, minio_user_key):
     minio = pytest.importorskip("minio")
     credentials = pytest.importorskip("minio.credentials")
     minio_admin = minio.MinioAdmin(
@@ -338,7 +333,7 @@ def minio_admin(minio_server, minio_alias, minio_user_key):
 
 
 @pytest.fixture
-def py_minio_client(minio_admin, minio_alias, minio_user_key):
+def py_minio_client(minio_admin, minio_user_key):
     minio = pytest.importorskip("minio")
     parsed_url = urlparse(MINIO_URL)
     yield minio.Minio(

diff --git a/daskms/tests/test_fsspec_store.py b/daskms/tests/test_fsspec_store.py
@@ -98,8 +98,6 @@ def test_store_subtable_access(tmp_path_factory):
 def test_minio_server(
     tmp_path,
     py_minio_client,
-    minio_admin,
-    minio_alias,
     minio_user_key,
     minio_url,
     s3_bucket_name,
@@ -126,8 +124,6 @@ def test_minio_server(
 def test_storage_options_from_config(
     tmp_path,
     py_minio_client,
-    minio_admin,
-    minio_alias,
     minio_user_key,
     minio_url,
     s3_bucket_name,