Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new minio.MinioAdmin client in test suite and update minio server version #298

Merged
merged 7 commits into from
Nov 13, 2023

Conversation

sjperkins
Copy link
Member

@sjperkins sjperkins commented Nov 13, 2023

The latest minio python client changed MinioAdmin to directly communicate with minio servers, instead of via the mc client binary. This PR updates the testing framework to use the new interface and no longer installs mc when testing. The minio server version has been updated to 11 November 2023.

Weekly cron job failed on newer python client here: https://github.com/ratt-ru/dask-ms/actions/runs/6844991970

  • Tests added / passed

    $ py.test -v -s daskms/tests

    If the pep8 tests fail, the quickest way to correct
    this is to run autopep8 and then flake8 and
    pycodestyle to fix the remaining issues.

    $ pip install -U autopep8 flake8 pycodestyle
    $ autopep8 -r -i daskms
    $ flake8 daskms
    $ pycodestyle daskms
    
  • Fully documented, including HISTORY.rst for all changes
    and one of the docs/*-api.rst files for new API

    To build the docs locally:

    pip install -r requirements.readthedocs.txt
    cd docs
    READTHEDOCS=True make html
    

@sjperkins sjperkins changed the title Using Python Minio Client and update Minio Server Version Use new minio.MinioAdmin client in test suite and update minio server version Nov 13, 2023
@sjperkins sjperkins merged commit 366bd32 into master Nov 13, 2023
13 checks passed
@sjperkins sjperkins deleted the minio-testing-updates branch November 13, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant