Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context optional and year to string. #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

evanscottgray
Copy link

@evanscottgray evanscottgray commented May 5, 2016

context should be optional because you can end up with a url that looks like my.subsonic.server/False/rest or my.subsonic.server/''/rest and mopidy itself will complain if you don't set it since it is not optional currently.

I suppose this is a duplicate of #19 but I think offering it as an option feels nice in general.

then a fix to client to force data['year'] to a string which is basically #18.

this also addresses #14, #15

…se or '' causes incorrect URL generation for subsonic api endpoint.
@ronihcohen
Copy link

Hey @evanscottgray, did this fix work for you? I am still getting the following err:

2016-08-20 20:06:00,015 ERROR [3011:MainThread] mopidy.commands: Got un-handled exception from SubsonicBackend
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mopidy/commands.py", line 237, in _actor_error_handling
    yield
  File "/usr/lib/python2.7/dist-packages/mopidy/commands.py", line 385, in start_backends
    config=config, audio=audio).proxy()
  File "/usr/lib/python2.7/dist-packages/pykka/actor.py", line 94, in start
    obj = cls(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/mopidy_subsonic/actor.py", line 32, in __init__
    self.playlists = SubsonicPlaylistsProvider(backend=self)
  File "/usr/local/lib/python2.7/dist-packages/mopidy_subsonic/playlist.py", line 15, in __init__
    self.playlists = self._get_playlists()
  File "/usr/local/lib/python2.7/dist-packages/mopidy_subsonic/playlist.py", line 36, in _get_playlists
    playlists = self.remote.get_user_playlists()
  File "/usr/local/lib/python2.7/dist-packages/mopidy_subsonic/client.py", line 364, in get_user_playlists
    for playlist in results]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants