Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autofree of GKeyFile in config-file.c #35

Merged
merged 1 commit into from
May 13, 2020

Conversation

prevas-lkmi
Copy link
Collaborator

GKeyFile is declared with g_autofree which is wrong. This fix use
g_autoptr with auto cleanup function registered for GKeyFile.

How it is related to segfault in #21, I'm not sure.

Fixes #21

Signed-off-by: Lasse K. Mikkelsen lasse.klok@prevas.dk

@prevas-lkmi prevas-lkmi requested a review from ejoerns May 12, 2020 07:59
Copy link
Contributor

@Raphexion Raphexion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GKeyFile is declared with g_autofree which is wrong. This fix use
g_autoptr with auto cleanup function registered for GKeyFile.

How it is related to segfault in rauc#21, I'm not sure.

Fixes rauc#21

Signed-off-by: Lasse K. Mikkelsen <lasse.klok@prevas.dk>
@prevas-lkmi prevas-lkmi force-pushed the lkmi/fix-autofree-config-file branch from e2aa984 to 6f870f2 Compare May 12, 2020 13:00
@prevas-lkmi prevas-lkmi merged commit 7b97849 into rauc:master May 13, 2020
@einoj einoj mentioned this pull request Nov 6, 2020
einoj added a commit to einoj/meta-rauc that referenced this pull request Nov 6, 2020
Update to a revision that doesn't segfault, see rauc/rauc-hawkbit-updater#21 and rauc/rauc-hawkbit-updater#35

Signed-off-by: Eino Juhani Oltedal <einoju@gmail.com>
einoj added a commit to einoj/meta-rauc that referenced this pull request Nov 9, 2020
Update to a revision that doesn't segfault, see rauc/rauc-hawkbit-updater#21 and rauc/rauc-hawkbit-updater#35

Signed-off-by: Eino Juhani Oltedal <einoju@gmail.com>
einoj added a commit to einoj/meta-rauc that referenced this pull request Nov 10, 2020
Update to a revision that doesn't segfault, see rauc/rauc-hawkbit-updater#21 and rauc/rauc-hawkbit-updater#35

Signed-off-by: Eino Juhani Oltedal <einoju@gmail.com>
einoj added a commit to einoj/meta-rauc that referenced this pull request Nov 10, 2020
Bump rauc-hawkbit-updater to latest commit.
Update to a revision that doesn't segfault, see rauc/rauc-hawkbit-updater#21 and rauc/rauc-hawkbit-updater#35

Signed-off-by: Eino Juhani Oltedal <einoju@gmail.com>
ejoerns pushed a commit to rauc/meta-rauc that referenced this pull request Nov 10, 2020
Bump rauc-hawkbit-updater to latest commit.
Update to a revision that doesn't segfault, see rauc/rauc-hawkbit-updater#21 and rauc/rauc-hawkbit-updater#35

Signed-off-by: Eino Juhani Oltedal <einoju@gmail.com>
ejoerns pushed a commit to ejoerns/meta-rauc that referenced this pull request Feb 12, 2021
Bump rauc-hawkbit-updater to latest commit.
Update to a revision that doesn't segfault, see rauc/rauc-hawkbit-updater#21 and rauc/rauc-hawkbit-updater#35

Signed-off-by: Eino Juhani Oltedal <einoju@gmail.com>
(cherry-picked from commit 4944494)
Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
einoj added a commit to einoj/meta-rauc that referenced this pull request Mar 5, 2021
Bump rauc-hawkbit-updater to latest commit.
Update to a revision that doesn't segfault, see rauc/rauc-hawkbit-updater#21 and rauc/rauc-hawkbit-updater#35

Signed-off-by: Eino Juhani Oltedal <einoju@gmail.com>
einoj added a commit to einoj/meta-rauc that referenced this pull request Mar 5, 2021
Bump rauc-hawkbit-updater to latest commit.
Update to a revision that doesn't segfault, see rauc/rauc-hawkbit-updater#21 and rauc/rauc-hawkbit-updater#35

Signed-off-by: Eino Juhani Oltedal <einoju@gmail.com>
Signed-off-by: Eino Juhani Oltedal <ejo@datarespons.no>
smk-embedded pushed a commit to phytec/meta-yogurt that referenced this pull request Apr 28, 2021
Bump rauc-hawkbit-updater to latest commit.
Update to a revision that doesn't segfault, see rauc/rauc-hawkbit-updater#21 and rauc/rauc-hawkbit-updater#35

Signed-off-by: Eino Juhani Oltedal <einoju@gmail.com>
Signed-off-by: Martin Schwan <m.schwan@phytec.de>
(cherry-picked from commit 494449469e75
github.com/rauc/meta-rauc master)
Signed-off-by: Stefan Müller-Klieser <s.mueller-klieser@phytec.de>
a3f pushed a commit to a3f/meta-rauc that referenced this pull request Nov 5, 2021
Bump rauc-hawkbit-updater to latest commit.
Update to a revision that doesn't segfault, see rauc/rauc-hawkbit-updater#21 and rauc/rauc-hawkbit-updater#35

Signed-off-by: Eino Juhani Oltedal <einoju@gmail.com>
(cherry-picked from commit 4944494)
Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thread 10 "gdbus" received SIGSEGV. Segmentation Fault
3 participants