Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form validation error style by default in FF #31

Open
raucao opened this issue Dec 19, 2016 · 4 comments
Open

Form validation error style by default in FF #31

raucao opened this issue Dec 19, 2016 · 4 comments
Labels

Comments

@raucao
Copy link
Owner

raucao commented Dec 19, 2016

I just upgraded to Ember 2.10.0 and then saw a weird issue during testing (not sure if it was there in master before): when going to /new in Firefox, the required fields are already marked invalid, even before trying to submit the form:

screenshot from 2016-12-19 21-57-17

@raucao raucao added the bug label Dec 19, 2016
@raucao raucao changed the title Form validations errors in FF Form validation errors in FF Dec 19, 2016
@raucao raucao changed the title Form validation errors in FF Form validation error style by default in FF Dec 19, 2016
@galfert
Copy link
Collaborator

galfert commented Dec 19, 2016

The fields are neither marked as invalid for me in the currently deployed version with Ember 1.6.0 nor with the Ember 2.7.3 version.

@galfert
Copy link
Collaborator

galfert commented Dec 19, 2016

This indeed seems to be a regression with Ember 2.10.0.

Using this Ember Twiddle you can switch between the current Ember release and version 2.9.0 in the "Dependencies" menu to see the different behavior.

I created an issue with the Ember repo for this.

@raucao
Copy link
Owner Author

raucao commented Dec 20, 2016

Very nice, thank you!

@raucao
Copy link
Owner Author

raucao commented Jan 29, 2019

Just FYI for whoever is following: this is still an issue in upstream Ember.js, but it looks like there's finally some activity around resolving it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants