You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Twitter uses the same technique as Slacking to embed a badge, however, they send an object in e.data instead of a string, so while the badges will end up both working on the page you end up with a javascript error in your console because you can't substr and object.
I believe the bug is on this line: https://github.com/rauchg/slackin/blob/master/lib/assets/badge.js#L76
Twitter uses the same technique as Slacking to embed a badge, however, they send an
object
ine.data
instead of a string, so while the badges will end up both working on the page you end up with a javascript error in your console because you can'tsubstr
and object.I believe the fix would be to rewrite:
as:
Thoughts?
The text was updated successfully, but these errors were encountered: