Bug when trying to use Slackin badge and Twitter follow badge on same page

[paltman]

I believe the bug is on this line: https://github.com/rauchg/slackin/blob/master/lib/assets/badge.js#L76

Twitter uses the same technique as Slacking to embed a badge, however, they send an object in e.data instead of a string, so while the badges will end up both working on the page you end up with a javascript error in your console because you can't substr and object.

I believe the fix would be to rewrite:

if (wp == e.data.substr(0, wp.length))

as:

if (typeof e.data === "string" && wp === e.data.substr(0, wp.length))

Thoughts?

[riknoll]

I'm having the same problem. Are there any plans to issue a fix?