remove default limit of records when generating a seed file

raul338 · Oct 8, 2015 · a7e0dfd · a7e0dfd
1 parent 4b208a9
commit a7e0dfd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/Shell/SchemaShell.php b/src/Shell/SchemaShell.php
@@ -121,7 +121,7 @@ public function getOptionParser()
             'default' => false
         ])->addOption('count', [
             'help' => 'Set the limit when generating seed',
-            'default' => 10
+            'default' => false
         ]);
     }
 }
diff --git a/src/Shell/Task/SeedGenerateTask.php b/src/Shell/Task/SeedGenerateTask.php
@@ -129,15 +129,18 @@ public function templateData()
      */
     protected function _getRecordsFromTable($modelName, $useTable = null)
     {
-        $recordCount = (isset($this->params['count']) ? $this->params['count'] : 10);
+        $recordCount = (isset($this->params['count']) ? $this->params['count'] : false);
         $conditions = (isset($this->params['conditions']) ? $this->params['conditions'] : '1=1');
         $model = $this->findModel($modelName, $useTable);
 
         $records = $model->find('all')
             ->where($conditions)
-            ->limit($recordCount)
             ->hydrate(false);
 
+        if ($recordCount) {
+            $records->limit($recordCount);
+        }
+
         return $records;
     }