Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Issues: Icon Component Grid #68

Open
mcorkum opened this issue Oct 4, 2019 · 5 comments
Open

Docs Issues: Icon Component Grid #68

mcorkum opened this issue Oct 4, 2019 · 5 comments
Assignees
Labels
bug Something isn't working Docs only low priority

Comments

@mcorkum
Copy link
Collaborator

mcorkum commented Oct 4, 2019

These issues are not directly related to blocks, but errors I found on documentation pages specifically. These are non-critical, but should be addressed at some point.

@mcorkum
Copy link
Collaborator Author

mcorkum commented Oct 4, 2019

On icon component page, the rollover text in red looks misaligned. Also on IE11, the grid will not extend beyond 3 items

Screen Shot 2019-10-04 at 11 05 31 AM

IE11:
Screen Shot 2019-10-04 at 11 05 57 AM

@troychaplin
Copy link
Contributor

One of the issues here is happening because there are hidden items inside u-grid... Even though there are hidden inputs, the grid has no way of knowing these are hidden and they are being considered a grid item.

I tested the removal of all the input items in the grid layout, and things work just fine (not including the red button issue)

@troychaplin
Copy link
Contributor

I fixed the issue with the red button

@troychaplin troychaplin changed the title Minor Issues Icon Component Grid Issue Oct 7, 2019
@troychaplin troychaplin added the bug Something isn't working label Oct 7, 2019
@troychaplin
Copy link
Contributor

Assigned to @dannybrown73 for further clarification on whether or not the input items need to sit outside each grid item

@troychaplin troychaplin added the help wanted Extra attention is needed label Oct 7, 2019
@dannybrown73
Copy link
Contributor

This is not a part of RDS and is only in the docs theme. It should be fixed but not required for 1.0 so going to mark as low priority and create a 'Docs only' tag.

@dannybrown73 dannybrown73 added Docs only low priority and removed help wanted Extra attention is needed labels Oct 8, 2019
@troychaplin troychaplin changed the title Icon Component Grid Issue Docs Issues: Icon Component Grid Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Docs only low priority
Projects
None yet
Development

No branches or pull requests

3 participants