Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility - Login / Search dialogs #80

Closed
mcorkum opened this issue Oct 17, 2019 · 3 comments
Closed

Accessibility - Login / Search dialogs #80

mcorkum opened this issue Oct 17, 2019 · 3 comments
Assignees
@troychaplin

Comments

@mcorkum
Copy link
Collaborator

mcorkum commented Oct 17, 2019

Needs aria controls
@troychaplin
Copy link
Contributor

@mcorkum what part of this needs aria controls? A specific element? When they are used as a part of an overlay? Can you please provide more information?

@mcorkum
Copy link
Collaborator Author

mcorkum commented Oct 17, 2019

https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/dialog.html

The element clicked needs to have aria-haspopup="true" and aria-labelledby=[IDofElement]

When clicked, the hidden div should have aria-hidden=true and it should change to aria-hidden=true

@mcorkum mcorkum assigned troychaplin and unassigned mcorkum Oct 17, 2019
@troychaplin
Copy link
Contributor

Referenced in #77, keeping all masthead accessibility issues in one spot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@troychaplin troychaplin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcorkum @troychaplin