Child code objects fixes #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`hasPatWithPid` invokes `childCodeObjects`, which we want to change, so now's a good time to delete it
Previously, `childCodeObjects` would return targets before and after an element as children of that element. This made it difficult to get Deuce selection/hover polygons working correctly. This change makes it so that a before target is instead the prior sibling of the element it precedes. After targets are removed in the general case since they're not always appropriate, but they're added in several cases, such as after list elements, where they are useful but previously missing. This commit also makes other changes, so that text selection should still work, and so that the `Exp` comments are more accurate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.