Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests don't pass locally #188

Closed
edg-l opened this issue May 18, 2023 · 3 comments · Fixed by #210
Closed

tests don't pass locally #188

edg-l opened this issue May 18, 2023 · 3 comments · Fixed by #210
Labels
bug Something isn't working

Comments

@edg-l
Copy link
Contributor

edg-l commented May 18, 2023

An important note is that i have llvm compiled with assertions on.

melior-2d0b8d39558e8344: /.../llvm-project-16.0.0.src/mlir/lib/IR/BuiltinAttributes.cpp:924: static mlir::DenseElementsAttr mlir::DenseElementsAttr::get(mlir::ShapedType, ArrayRef<mlir::Attribute>): Assertion `intAttr.getType() == eltType && "expected integer attribute type to equal element type"' failed.
test dialect::scf::tests::compile_index_switch ... ok
error: test failed, to rerun pass `-p melior --lib`

Caused by:
  process didn't exit successfully: `/.../melior/target/debug/deps/melior-2d0b8d39558e8344` (signal: 6, SIGABRT: process abort signal)

Since it SIGABRT it's hard to pointpoint what test causes it

@raviqqe
Copy link
Owner

raviqqe commented May 18, 2023

#189 might have fixed it; at least the test was wrong before. Could you confirm it locally?

@edg-l
Copy link
Contributor Author

edg-l commented May 18, 2023

I get another assert now

...
test ir::attribute::array::tests::len ... ok
test ir::attribute::dense_elements::tests::i64_element ... ok
test ir::attribute::dense_elements::tests::i32_element ... ok
melior-8bc0089116d49e9d: /.../llvm-project-16.0.4.src/llvm/include/llvm/Support/Casting.h:567: decltype(auto) llvm::cast(const From&) [with To = mlir::ArrayAttr; From = mlir::Attribute]: Assertion `isa<To>(Val) && "cast<Ty>() argument of incompatible type!"' failed.
test dialect::memref::tests::compile_store_with_index ... ok
error: test failed, to rerun pass `-p melior --lib`

Caused by:
  process didn't exit successfully: `/.../melior/target/debug/deps/melior-8bc0089116d49e9d` (signal: 6, SIGABRT: process abort signal)

@raviqqe raviqqe added the bug Something isn't working label May 19, 2023
@raviqqe
Copy link
Owner

raviqqe commented May 19, 2023

I should probably build LLVM on my machine. 😅

raviqqe pushed a commit that referenced this issue Jun 1, 2023
fixes #188 

i also fixed some tests using unregistered dialects (catched with llvm
assertions on)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants