Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formspree phasing out legacy forms that use email address as part of the form action #10

Closed
morozgrafix opened this issue Oct 22, 2020 · 2 comments

Comments

@morozgrafix
Copy link
Contributor

morozgrafix commented Oct 22, 2020

Is your feature request related to a problem? Please describe.

Formspree is phasing out legacy forms (email URLs).

<form action="https://formspree.io/your@email.com" method="POST"> is considered to be a legacy URL. Newly created forms utilize form_id URL path like <form action="https://formspree.io/f/a_form_id" method="POST">

Describe the solution you'd like

It may be a good idea to introduce another site configuration variable, for example formspree_form_path that will be utilized for contact_me form (relevant files _config.yml, _includes/contact.html and assets/js/contact_me.js)

Describe alternatives you've considered

None

Additional context

Formspree articles related to the upcoming change: https://help.formspree.io/hc/en-us/articles/360017735154-How-to-prevent-spam and https://help.formspree.io/hc/en-us/articles/360056076314

morozgrafix added a commit to morozgrafix/agency-jekyll-theme that referenced this issue Oct 22, 2020
Solution may work for raviriley#10

Should maintain backwards compatibility if `formspree_path` is not set in older `_config.yml` installations.

Tested only locally, may need additional testing.
morozgrafix added a commit to morozgrafix/agency-jekyll-theme that referenced this issue Oct 22, 2020
Solution may work for raviriley#10

Should maintain backwards compatibility if `formspree_form_path` is not set in older `_config.yml` installations.

Tested only locally, may need additional testing.

comment out formspree_form_path for backwards compatibility
@morozgrafix
Copy link
Contributor Author

PR submitted.

There are also minor trailing whitespace cleanup along with the changes.

@raviriley
Copy link
Owner

Merged

dkbnz pushed a commit to dkbnz/agency-jekyll-theme that referenced this issue Jul 12, 2022
Solution may work for raviriley#10

Should maintain backwards compatibility if `formspree_form_path` is not set in older `_config.yml` installations.

Tested only locally, may need additional testing.

comment out formspree_form_path for backwards compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants