Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeBSD linker (lld) needs to support -framework and -F search path #10

Closed
mszoek opened this issue Mar 9, 2021 · 1 comment · Fixed by #16
Closed

FreeBSD linker (lld) needs to support -framework and -F search path #10

mszoek opened this issue Mar 9, 2021 · 1 comment · Fixed by #16
Assignees
@mszoek
Labels
Framework Affecting a framework bundle or tools that build them i can haz? New feature or request
Projects
Airyx Development

Comments

@mszoek
Copy link
Collaborator

mszoek commented Mar 9, 2021

No description provided.

@mszoek mszoek added i can haz? New feature or request AppDir Framework Affecting a framework bundle or tools that build them labels Mar 9, 2021
@mszoek mszoek self-assigned this Mar 9, 2021
@mszoek mszoek added this to To do in Airyx Development via automation Mar 9, 2021
@mszoek
Copy link
Collaborator Author

mszoek commented Mar 9, 2021

This limitation is worked around by the he.app.mk makefile but these options should be properly supported.

@mszoek mszoek mentioned this issue Mar 13, 2021
Merged
Airyx Development automation moved this from To do to Done Mar 13, 2021
mszoek pushed a commit that referenced this issue Aug 18, 2023
@kprovost
mroute: avoid calling if_allmulti with the lock held
680ad06 
Avoid locking issues when if_allmulti() calls the driver's if_ioctl,
because that may acquire sleepable locks (while we hold a non-sleepable
rwlock).

Fortunately there's no pressing need to hold the mroute lock while we
do this, so we can postpone the call slightly, until after we've
released the lock.

This avoids the following WITNESS warning (with iflib drivers):

	lock order reversal: (sleepable after non-sleepable)
	 1st 0xffffffff82f64960 IPv4 multicast forwarding (IPv4 multicast forwarding, rw) @ /usr/src/sys/netinet/ip_mroute.c:1050
	 2nd 0xfffff8000480f180 iflib ctx lock (iflib ctx lock, sx) @ /usr/src/sys/net/iflib.c:4525
	lock order IPv4 multicast forwarding -> iflib ctx lock attempted at:
	#0 0xffffffff80bbd6ce at witness_checkorder+0xbbe
	#1 0xffffffff80b56d10 at _sx_xlock+0x60
	#2 0xffffffff80c9ce5c at iflib_if_ioctl+0x2dc
	#3 0xffffffff80c7c395 at if_setflag+0xe5
	#4 0xffffffff82f60a0e at del_vif_locked+0x9e
	#5 0xffffffff82f5f0d5 at X_ip_mrouter_set+0x265
	#6 0xffffffff80bfd402 at sosetopt+0xc2
	#7 0xffffffff80c02105 at kern_setsockopt+0xa5
	#8 0xffffffff80c02054 at sys_setsockopt+0x24
	#9 0xffffffff81046be8 at amd64_syscall+0x138
	#10 0xffffffff8101930b at fast_syscall_common+0xf8

See also:	https://redmine.pfsense.org/issues/12079
Reviewed by:	mjg
Sponsored by:	Rubicon Communications, LLC ("Netgate")
Differential Revision:	https://reviews.freebsd.org/D41209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mszoek mszoek

Labels
Framework Affecting a framework bundle or tools that build them i can haz? New feature or request
Projects
No open projects
Airyx Development
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[10] Add framework support to LLVM ELF linker ravynsoft/ravynos
1 participant
@mszoek