Calling operator + on ActiveRecord::Relation force loading all rows from database and doesn't return a new Relation object

[kmatrah]

In ActiveRecord::FriendModel, in the instance methods, calling operator + on 2 relations force loading all rows from database to merge the 2 relations.

Exemple: lib / amistad / active_record / friend_model.rb line 68-70:
def friends
self.invited(true) + self.invited_by(true)
end

The friends method returns an Array instead of an ActiveRecord::Relation object and it's not possible anymore to chain any ActiveRecord query method like offset, limit and order.

Is it possible to update the gem and use the method merge from ActiveRecord::SpawnMethods to merge the two Relation objects and get a new one ?

def friends
self.invited(true).merge self.invited_by(true)
end

[raw1z]

I am working on it. Thank you for your suggestion.

Le 5 juil. 2011 à 12:10, kmatrah a écrit :

In ActiveRecord::FriendModel, in the instance methods, calling operator + on 2 relations force loading all rows from database to merge the 2 relations.

Exemple: lib / amistad / active_record / friend_model.rb line 68-70:
def friends
self.invited(true) + self.invited_by(true)
end

The friends method returns an Array instead of an ActiveRecord::Relation object and it's not possible anymore to chain any ActiveRecord query method like offset, limit and order.

Is it possible to update the gem and use the method merge from ActiveRecord::SpawnMethods to merge the two Relation objects and get a new one ?

def friends
self.invited(true).merge self.invited_by(true)
end

Reply to this email directly or view it on GitHub:
#12