Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WAL mode for the database #17

Merged
merged 2 commits into from Apr 27, 2018
Merged

Use WAL mode for the database #17

merged 2 commits into from Apr 27, 2018

Conversation

wmertens
Copy link

@wmertens wmertens commented Aug 7, 2017

Fixes #15

Untested, and it splits the database file into 3 files. Perhaps this should be optional?

@rawberg
Copy link
Owner

rawberg commented Aug 8, 2017

I agree this should be optional. is there a clean way to support this if a user wants to opt into WAL mode?

@wmertens
Copy link
Author

wmertens commented Aug 8, 2017 via email

@wmertens
Copy link
Author

wmertens commented Aug 8, 2017

maybe something like

this.db.exec((options.concurrentDb ? 'PRAGMA journal_mode = wal; ' : '') + 'CREATE ......'

@wmertens
Copy link
Author

I added that option in the branch.

@rawberg rawberg merged commit 259c084 into rawberg:master Apr 27, 2018
@rawberg
Copy link
Owner

rawberg commented Apr 27, 2018

merged and published to NPM, thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants