Make localItemSelector reactive to changes from itemSelector prop

rawilk · Jul 28, 2019 · bf58a42 · bf58a42
1 parent 941e8f6
commit bf58a42
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 7 deletions.
diff --git a/dist/js/vue-context.js b/dist/js/vue-context.js
diff --git a/src/js/vue-context.js b/src/js/vue-context.js
@@ -49,16 +49,12 @@ export default {
             left: null,
             show: false,
             data: null,
-            localItemSelector: this.itemSelector
+            localItemSelector: ''
         };
     },
 
     created() {
-        if (isArray(this.localItemSelector)) {
-            this.localItemSelector = this.localItemSelector
-                .map(selector => `${selector}:not(.disabled):not([disabled])`)
-                .join(', ');
-        }
+        this.localItemSelector = this.mapItemSelector(this.itemSelector);
     },
 
     beforeDestroy() {
@@ -126,6 +122,16 @@ export default {
             return filterVisible(selectAll(this.localItemSelector, this.$el));
         },
 
+        mapItemSelector(itemSelector) {
+            if (isArray(itemSelector)) {
+                itemSelector = itemSelector
+                    .map(selector => `${selector}:not(.disabled):not([disabled])`)
+                    .join(', ');
+            }
+
+            return itemSelector;
+        },
+
         onClick() {
             this.close();
         },
@@ -211,6 +217,12 @@ export default {
                 this.removeScrollEventListener();
             }
         },
+
+        itemSelector(selector, oldValue) {
+            if (selector !== oldValue) {
+                this.localItemSelector = this.mapItemSelector(selector);
+            }
+        }
     },
 
     render(h) {