PoC tool to switch underlying DTLS transports of an SCTP transport #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransport instance Add `rawrtc_sctp_transport_set_transport` and `rawrtc_sctp_transport_get_transport` functions Add 'data-channel-sctp-swap-dtls-transport' tool Update readme to reflect the new tool (it might make sense to migrate all the other tools to the code base, too)
lgrahl
commented
Sep 24, 2017
| // Attach to DTLS transport | ||
| // Note: The function checks if a data transport is already registered for us | ||
| DEBUG_PRINTF("Attaching as data transport\n"); | ||
| error = rawrtc_dtls_transport_set_data_transport( |
There was a problem hiding this comment.
It should be possible to add multiple SCTP transports. data_transport transport is also incorrect, it should be sctp_transport. This should be changed once we have proper multiplexing.
|
I think I made my point for w3c/ortc#775. As a tool, it's not really that useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done as a PoC for w3c/ortc#775.
Can be merged once that PR has been merged.