George/fix mplot queries #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public static Points<BluefloodEnumRollup> generateFakeEnumRollupPoints() { | ||
| Points<BluefloodEnumRollup> points = new Points<BluefloodEnumRollup>(); | ||
| long startTime = 1234567L; | ||
| for (int i = 0; i < 5; i++) { |
There was a problem hiding this comment.
I am a bit confused why we are generating fake enum rollup points. Is this method only being called in Test classes? If so, should we move it to some class in src/test/java ?
|
The rest of the changes look good, to a novice pair of eyes. ;-) +1. Someone else should probably review too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the exception generated by enum mplot queries:
java.lang.Exception: average not supported for this type: BluefloodEnumRollup
Multiplot enum and gauge queries were not treating default filterStats the same as singlePlot queries. This PR refactors the code so singlePlot and multiPlot work the same.
Also added another logmessage for rollups.