remove log.error() on cases where it's not really system error #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@usnavi @ChandraAddala @izrik pls review |
ChandraAddala
approved these changes
Feb 7, 2017
| DefaultHandler.sendErrorResponse(ctx, request, ex.getMessage(), HttpResponseStatus.BAD_REQUEST); | ||
| } catch (TimeoutException ex) { | ||
| DefaultHandler.sendErrorResponse(ctx, request, "Timed out persisting metrics", HttpResponseStatus.ACCEPTED); | ||
| } catch (Exception ex) { | ||
| log.debug(String.format("BAD JSON: %s", body)); | ||
| log.debug(String.format("Exception processing: %s", body)); |
There was a problem hiding this comment.
If we get some exception which we are not expecting, I think we need some visibility to it. Should we log error here?
There was a problem hiding this comment.
There is already a log.error(). See the line below.
ChandraAddala
approved these changes
Feb 7, 2017
usnavi
approved these changes
Feb 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove calls to log.error() as an invalid user input should not be considered an error