add a github workflow #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a workflow named "test" so that pull requests will be tested and given a commit status, which is a pre-requisite for merging now. I also add a shrinkwrap file here because we're currently on node 0.10.33, which doesn't support any other kind of dependency locking that I know of. With this file present, an `npm install` will install the versions specified here instead of in package.json. It effectively acts as a `package-lock.json` file, but that's introduced much later in npm's life. Eventually, we'll have to switch over because shrinkwrap is deprecated in favor of `package-lock.json`. For now, this will let us ensure we're using the correct depenedency versions in dev. I pulled this from a current dreadnot production deployment.
iWebi
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a workflow named "test" so that pull requests will be tested
and given a commit status, which is a pre-requisite for merging now.
I also add a shrinkwrap file here because we're currently on node
0.10.33, which doesn't support any other kind of dependency locking
that I know of. With this file present, an
npm installwill installthe versions specified here instead of in package.json. It effectively
acts as a
package-lock.jsonfile, but that's introduced much laterin npm's life. Eventually, we'll have to switch over because
shrinkwrap is deprecated in favor of
package-lock.json. For now,this will let us ensure we're using the correct depenedency versions
in dev. I pulled this from a current dreadnot production deployment.