feat(api/deploy): Default to redeploy if to_revision is not set #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion by making it default to current revision of that stack thats been deployed
kaustavha
force-pushed
the
kaustavha/feat/auto-deploy
branch
from
1021687
to
45b531d
Compare
| @@ -77,34 +77,30 @@ exports.getAPIHandlers = function(dreadnot, authdb) { | |||
| // stack locked errors, redirect to the region view, otherwise a full error | |||
| // view. | |||
| function deploy(req, res) { | |||
| var stackName = req.params.stack, | |||
| var stackName = req.params.stack, | |||
There was a problem hiding this comment.
looks like your formatting is out of whack. var is indented 6 spaces..
mburns
changed the title
|
Needs to be rebased/linted, but then I'm 👍 |
|
fixed. 👍 |
mburns
added a commit
that referenced
this pull request
Oct 22, 2015
feat(api/deploy): Default to redeploy if to_revision is not set
Might have to revert this unless someone wants to pop in with a fix pretty quick ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow automatic deploys without specifying to revision by making it default to current revision of that stack thats been deployed.
I noticed that in staging there's a specific revision that's been deployed over and over again, this should make that process easier.
Note: This PR does not make dreadnot auto-deploy to the latest git revision, only the git revision that's already been deployed and who's sha1 hash can be retrieved by running stack.getSummary.