fix: custom output dir #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClarkXia
reviewed
Nov 18, 2020
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| registry-url: https://registry.npmjs.org/ |
| @@ -66,7 +66,7 @@ module.exports = function (api) { | |||
| const { outputDir = 'build' } = userConfig; | |||
|
|
|||
| if (isSuccessful) { | |||
| if (commandArgs.disableAssets === false) { | |||
| if (commandArgs.enableAssets) { | |||
ClarkXia
approved these changes
Nov 18, 2020
SoloJiang
added a commit
that referenced
this pull request
Nov 23, 2020
* fix(miniapp): duplicated taskname when both ali and wechat are compiled * fix: compact react plugin targets is undefined (#490) * feat: rax-app support css modules (#488) * chore: CSS Modules * chore: style example * build(example): modify jsx compilerOptions to preserve in tsconfig * chore: optimize example * chore: upgrade dep version * chore: remove branch_name * chore: readme Co-authored-by: 逆葵 <xianyong.yxy@alibaba-inc.com> * fix: custom output dir (#494) * fix: custom output dir * fix: ci error * fix: ci error * fix: ci yml * chore: remove useless code * feat: add enable assets * fix: compatible with build-mpa-config (#499) * chore: bump version (#497) * chore: bump version * chore: update version * chore: update version * chore: update version * fix: dep check error * chore: add changelog * chore: update version * chore: update version Co-authored-by: 逆葵 <xianyong.yxy@alibaba-inc.com> Co-authored-by: NK <yxy0919@foxmail.com> Co-authored-by: 大果 <sobear.me@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复自定义输出目录失效的问题