Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use px in scaling #127

Merged
merged 1 commit into from Feb 19, 2020
Merged

feat: use px in scaling #127

merged 1 commit into from Feb 19, 2020

Conversation

yacheng
Copy link
Contributor

@yacheng yacheng commented Feb 15, 2020

当图片宽度为 px 单位时,当前计算规则无法根据真实图片尺寸进行缩放,因为只计算了 rpx 的情况。
当图片单位为 rem vw 等单位时,在无法匹配适合最小宽度的情况下会走默认值与当前逻辑一致

@boiawang
Copy link
Contributor

+1

@boiawang boiawang self-requested a review February 17, 2020 02:38
@yuanyan yuanyan merged commit 26c2f92 into master Feb 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/rax-picture branch February 19, 2020 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants