Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autoscaling group #113

Closed
raxod502 opened this issue Sep 15, 2021 · 1 comment
Closed

Remove autoscaling group #113

raxod502 opened this issue Sep 15, 2021 · 1 comment

Comments

@raxod502
Copy link
Member

https://riju.statuspage.io/incidents/3j942jd9q374 was caused basically because autoscaling groups are confusing. I still don't fully understand what happened. But it occurred to me that the autoscaling group itself isn't really doing anything here, after all we're not actually doing any autoscaling.

Instead, we can just define the target group, and add/remove instances to the target group directly. That should cover everything we need. We can also write a script to handle the common case of rolling the instances with a new AMI.

@raxod502
Copy link
Member Author

Done in the above-linked commit. See also https://riju.statuspage.io/incidents/s6dr9yjvqxy2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant