Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Coriolis work in all coordinate pairs #9

Open
ray-chew opened this issue Mar 21, 2024 · 1 comment
Open

Make Coriolis work in all coordinate pairs #9

ray-chew opened this issue Mar 21, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ray-chew
Copy link
Owner

ray-chew commented Mar 21, 2024

For now, vertical slices with gravity are in the x-y plane, while horizontal slices with Coriolis are in the x-z plane. Simulations in the x-z plane are solved with a quasi-3D array, i.e. the full grid-size on the x-z plane and in the y-axis, 5 layers of the cellular grid and 6 layers of the nodal grid. These vertical layers comprise the 4 ghost layers.

Making Coriolis simulations work with a truly 2D array will decrease computation time significantly. Two possibilities are:

  1. Make it possible for the code to solve x-z plane problems in 2D or
  2. extend the x-y plane to support Coriolis.

Option 2. seems to be easier for now, but option 1. will simplify extension to 3D in the future.

@ray-chew ray-chew changed the title Cleanly separate Blending module Make Coriolis work in all coordinate pairs Mar 21, 2024
@ray-chew
Copy link
Owner Author

Consequently, gravity must work in all coordinate directions as well.

@ray-chew ray-chew added enhancement New feature or request help wanted Extra attention is needed labels Mar 21, 2024
@ray-chew ray-chew self-assigned this Mar 21, 2024
@ray-chew ray-chew removed the help wanted Extra attention is needed label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant