Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump phpstan #186

Merged
merged 11 commits into from
Jan 28, 2022
Merged

Bump phpstan #186

merged 11 commits into from
Jan 28, 2022

Conversation

NaokiTsuchiya
Copy link
Member

@NaokiTsuchiya NaokiTsuchiya commented Jan 22, 2022

1e44a88 だけ上手く解決できませんでした。

以下だと問題ないんですが。
https://psalm.dev/r/5db9162108

Error: InvalidReturnType: The declared return type 'T:fn-ray\aop\compilerinterface::newinstance as object' for Ray\Aop\Compiler::newInstance is incorrect, got 'T'
Error: InvalidReturnStatement: The inferred type 'T' does not match the declared return type 'T:fn-ray\aop\compilerinterface::newinstance as object' for Ray\Aop\Compiler::newInstance

@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #186 (d63c7bc) into 2.x (cea5d37) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                 2.x      #186   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       168       168           
===========================================
  Files             29        29           
  Lines            496       498    +2     
===========================================
+ Hits             496       498    +2     
Impacted Files Coverage Δ
src/Compiler.php 100.00% <100.00%> (ø)
src/Weaver.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea5d37...d63c7bc. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@koriym koriym merged commit f6076c0 into ray-di:2.x Jan 28, 2022
@NaokiTsuchiya NaokiTsuchiya deleted the phpstan branch April 1, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants