Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong compiled method of parent #188

Merged
merged 8 commits into from
Feb 21, 2022
Merged

Fix wrong compiled method of parent #188

merged 8 commits into from
Feb 21, 2022

Conversation

NaokiTsuchiya
Copy link
Member

Fixed #187

@NaokiTsuchiya NaokiTsuchiya changed the title Add red test Fix wrong compiled of parent method Feb 19, 2022
@NaokiTsuchiya NaokiTsuchiya changed the title Fix wrong compiled of parent method Fix wrong compiled method of parent Feb 19, 2022
@codecov
Copy link

codecov bot commented Feb 19, 2022 •
edited

Codecov Report

Merging #188 (151e3b9) into 2.x (f6076c0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                 2.x      #188   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       168       171    +3     
===========================================
  Files             29        29           
  Lines            498       508   +10     
===========================================
+ Hits             498       508   +10
Impacted Files Coverage Δ
src/AopClass.php 100.00% <100.00%> (ø)
src/AopProps.php 100.00% <100.00%> (ø)
src/CodeVisitor.php 100.00% <100.00%> (ø)
src/VisitorFactory.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6076c0...151e3b9. Read the comment docs.

@NaokiTsuchiya NaokiTsuchiya marked this pull request as ready for review February 21, 2022 01:16
koriym
koriym requested changes Feb 21, 2022
View reviewed changes
src/CodeVisitor.php Outdated Show resolved Hide resolved
@koriym koriym self-requested a review February 21, 2022 12:05
@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@koriym koriym merged commit 7c5bcca into ray-di:2.x Feb 21, 2022
@NaokiTsuchiya NaokiTsuchiya deleted the fix/parent-intercept branch February 21, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koriym koriym koriym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong compiled method of parent
2 participants
@NaokiTsuchiya @koriym