Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

194 (reopened) #195

Merged
merged 19 commits into from
Sep 28, 2022
Merged

Conversation

koriym
Copy link
Member

@koriym koriym commented Sep 27, 2022

@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (d20d41a) compared to base (ba404c2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##                 2.x      #195   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       174       161   -13     
===========================================
  Files             29        30    +1     
  Lines            512       451   -61     
===========================================
- Hits             512       451   -61     
Impacted Files Coverage Δ
src/CodeGen.php 100.00% <ø> (ø)
src/CodeVisitor.php 100.00% <ø> (ø)
src/ReflectionClass.php 100.00% <ø> (ø)
src/AopClass.php 100.00% <100.00%> (ø)
src/CallIntercept.php 100.00% <100.00%> (ø)
src/CodeGenMethod.php 100.00% <100.00%> (ø)
src/InterceptTrait.php 100.00% <100.00%> (ø)
src/ReflectionMethod.php 100.00% <100.00%> (ø)
src/ReflectiveMethodInvocation.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koriym koriym marked this pull request as ready for review September 27, 2022 08:42
@koriym koriym merged commit 5084782 into ray-di:2.x Sep 28, 2022
@koriym koriym deleted the 193-organizing-the-generated-aop-code branch September 28, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants